Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: com.malawarecreator.neofile version 0.0.0.1 #201274

Conversation

malawarecreator
Copy link

@malawarecreator malawarecreator commented Dec 22, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@malawarecreator
Copy link
Author

@microsoft-github-policy-service agree

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Dec 22, 2024
@stephengillie
Copy link
Collaborator

Manual Validation ended with:

3:28:46 PM:
2024-12-23 15:28:36.155 [CORE] Download request failed. Returned status: 404 3:28:46 PM:
2024-12-23 15:28:36.230 [CLI ] Failed to download, waiting a bit and retry. Url: https://github.com/malawarecreator/neofile/raw/refs/heads/master/neofile.exe

(Automated response - build 931.)

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Dec 23, 2024
# Created using wingetcreate 1.9.2.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.9.0.schema.json

PackageIdentifier: com.malawarecreator.neofile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PackageIdentifier: com.malawarecreator.neofile
PackageIdentifier: malwarecreator.neofile

The preferred identifier is Publisher.Package. After updating this, the folder the manifest is in will need to be changed

# Created using wingetcreate 1.9.2.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.9.0.schema.json

PackageIdentifier: com.malawarecreator.neofile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PackageIdentifier: com.malawarecreator.neofile
PackageIdentifier: malwarecreator.neofile

The preferred identifier is Publisher.Package. After updating this, the folder the manifest is in will need to be changed

# Created using wingetcreate 1.9.2.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.9.0.schema.json

PackageIdentifier: com.malawarecreator.neofile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PackageIdentifier: com.malawarecreator.neofile
PackageIdentifier: malwarecreator.neofile

The preferred identifier is Publisher.Package. After updating this, the folder the manifest is in will need to be changed

# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.9.0.schema.json

PackageIdentifier: com.malawarecreator.neofile
PackageVersion: 0.0.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PackageVersion: 0.0.0.1
PackageVersion: 1.1

After changing this, the folder the manifest is in will need to be renamed

# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.9.0.schema.json

PackageIdentifier: com.malawarecreator.neofile
PackageVersion: 0.0.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PackageVersion: 0.0.0.1
PackageVersion: 1.1

After changing this, the folder the manifest is in will need to be renamed

# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.9.0.schema.json

PackageIdentifier: com.malawarecreator.neofile
PackageVersion: 0.0.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PackageVersion: 0.0.0.1
PackageVersion: 1.1

After changing this, the folder the manifest is in will need to be renamed

- neofile
Installers:
- Architecture: x64
InstallerUrl: https://github.com/malawarecreator/neofile/raw/refs/heads/master/neofile.exe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InstallerUrl: https://github.com/malawarecreator/neofile/raw/refs/heads/master/neofile.exe
InstallerUrl: https://github.com/malawarecreator/neofile/releases/download/v1.1/neofile.exe

@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jan 1, 2025
Copy link
Contributor

Hello @malawarecreator,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any recent activity. It will be closed if no further activity occurs within 3 days of this comment.

Template: msftbot/noRecentActivity

auto-merge was automatically disabled January 4, 2025 21:27

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Changes-Requested Changes Requested Needs-Author-Feedback This needs a response from the author. New-Package No-Recent-Activity No activity has occurred on this work item for seven days. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants